[Webkit-unassigned] [Bug 11678] [S60] tabbing navigation skips over text content

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=11678


zbujtas at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11608|review?(zbujtas at gmail.com)  |review-
               Flag|                            |




------- Comment #2 from zbujtas at gmail.com  2006-11-26 13:41 PDT -------
(From update of attachment 11608)
in getNewTabbedCursorPosition, you use the same variable name (as the parameter
of this function) to call the subframe's getNewTabbedCursorPosition. is it
intentional? as with this setup your nodeIndex remains -1 even if it is set to
something else in the subframe call. 

int nodeIndex = -1;
bool foundInFrame = foundFrame->getNewTabbedCursorPosition(lr,tb,nodeIndex);


in tabbedNavigation, it looks to me that nodeIndex can be easily -1 and that
crashes on the following line
QRect foundRect = (*_focusableNodeList)[nodeIndex];

and please remove the FIXME comment


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.