[Webkit-unassigned] [Bug 11667] SVG: method .getTransformToElement(elt) in SVGLocatable not implemented

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 26 13:09:28 PST 2006


------- Comment #5 from macdome at opendarwin.org  2006-11-26 13:09 PDT -------
(From update of attachment 11636)
Ok, I have two concerns.

1. We're mallocing when not necessary:
 +    SVGMatrix* ctm = SVGSVGElement::createSVGMatrix();
+    ctm->multiply(startctm);

In the error condition, no malloc is needed.  Ideally we would just move off of
SVGMatrix internally (this function could take/return AffineTransforms, and let
something outside of it do the wrapping).  I'm not sure it's worth going
through contortions to avoid mallocs in error conditions however.  Consider
making this an AffineTransform in/out function though.

2.  We need tests for the error conditions.  I see this behavior:
+        if (ec)
+            return ctm;

Does that match the spec?  Does that match firefox/opera?  It would be good to

Otherwise it looks fine.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list