[Webkit-unassigned] [Bug 11682] Gdk port needs to be updated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 25 09:35:50 PST 2006


http://bugs.webkit.org/show_bug.cgi?id=11682





------- Comment #2 from alp at atoker.com  2006-11-25 09:35 PDT -------
It's come to my attention that my patch contains a few leftover blocks of
commented-out code, and a little bad formatting.

Before I update the patch, I have a few questions:

1) Is it correct to remove the userAgent() function from FrameGdk following the
recent refactoring in the core, or is this area still being refactored and the
requirements uncertain?

2) There is currently one workaround in the patch which I'd like to remove.
I had to make m_client in FrameGdk public and assign its value as "new
FrameGdkClientDefault()" in main.cpp even though the FrameGdk constructor
already does this. If I don't set it outside the constructor,
frame->client()->openURL(url) in main.cpp segfaults. Any idea why the work done
in the constructor is not sufficient and I have to do it again in main.cpp for
gdklauncher to work?

If there is no certain answer to these issues, I'll update the patch regardless
in a couple of days and request review, as there are further changes lined up
that are being blocked by this one.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list