[Webkit-unassigned] [Bug 11628] REGRESSION (r17597): Command-return in native text fields doesn't open a new tab or window

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=11628


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|REGRESSION: Command-return  |REGRESSION (r17597):
                   |in native text fields       |Command-return in native
                   |doesn't open a new tab or   |text fields doesn't open a
                   |window                      |new tab or window
          Component|Forms                       |HTML DOM
                 CC|                            |mitz at webkit.org,
                   |                            |darin at apple.com




------- Comment #4 from mitz at webkit.org  2006-11-21 09:12 PDT -------
The regression is due to r17597, specifically "added DOM Event parameters to
various functions so that the handlers can use the DOM Event instead of the
global "current NSEvent";".

The problem is that when a Command-Return keyboard event triggers a simulated
click event, the click event doesn't inherit the modifiers from the mouse
event. This affects not only form fields but also focused links, and breaks to
the Option modifier as well. I think everything funnels through
HTMLElement::click(), and in the relevant cases the caller to click() still has
the original keyboard event which it could pass along if click() were modified
to take it.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.