[Webkit-unassigned] [Bug 11625] Investigate possibility to share code between HTMLStyleElement and SVGStyleElement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 18 17:54:47 PST 2006


------- Comment #5 from darin at apple.com  2006-11-18 17:54 PDT -------
(From update of attachment 11550)
The Document.cpp change is great, but it seems like a separate fix to me --
it's independent of the inheritance change.

THe new base class seems OK. It's good not to have two entire copies of the
code, even though we end up using multiple inheritance.

+    , StyleElement()

You should not need to explicitly invoke the base class's default constructor
like this.

+//fprintf(stderr, "isLoading %d\n", m_loading);

Please don't land these.

Why all the changes from AtomicString to String? When possible, it's great to
have functions take AtomicString parameters, in case you're already calling
with an atomic string -- saves a hash table lookup. And it's great to have
const AtomicString& return types instead of String in cases where that works --
much more efficient, but you can't always do it.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list