[Webkit-unassigned] [Bug 10122] Background composite property should apply to background color, not just images

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 16 21:25:04 PST 2006


http://bugs.webkit.org/show_bug.cgi?id=10122


timothy at hatcher.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11545|                            |review?
               Flag|                            |
             Status|NEW                         |ASSIGNED
         AssignedTo|webkit-                     |timothy at hatcher.name
                   |unassigned at opendarwin.org   |




------- Comment #2 from timothy at hatcher.name  2006-11-16 21:25 PDT -------
Created an attachment (id=11545)
 --> (http://bugs.webkit.org/attachment.cgi?id=11545&action=view)
Proposed patch

Makes -webkit-background-composite apply to background-color.
Adds compositeOperation() function to GraphicsContext.
Fixes functions in GraphicsContext that never drew when alpha() was 0,
this optimization only works when the compositeOperation is SourceOver.

* manual-tests/background-composite-color.html: Added.
* platform/graphics/GraphicsContext.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawRect): check the compositeOperation
(WebCore::GraphicsContext::drawEllipse): ditto
(WebCore::GraphicsContext::drawConvexPolygon): ditto
(WebCore::GraphicsContext::fillRect): ditto
* platform/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::compositeOperation): Added.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBackgroundExtended):


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list