[Webkit-unassigned] [Bug 11617] Compile and work on Qt/KDE platforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 16 09:11:43 PST 2006


http://bugs.webkit.org/show_bug.cgi?id=11617


sam.weinig at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11538|review?                     |review-
               Flag|                            |




------- Comment #2 from sam.weinig at gmail.com  2006-11-16 09:11 PDT -------
(From update of attachment 11538)
r- for a few missing things.

- Add the URL for this bug to the Changelog.
- #include "config.h" to ContextMenuClientQt.cpp.
- In ContextMenuClientQt.h, please but the opening curly-brace for the
namespace and the class on the same line as the declaration. Same goes for the
namespace in ContextMenuQt.cpp.
- No need for the braces around one line if statement in void
ContextMenu::appendItem(ContextMenuItem item)

- These last two are really nitpicking, but, in EditorClientQt.cpp, please
separate the #include "EditCommand.h" from the first 2 #includes as is our
style.  And, at the end of ContextMenuClientQt.cpp you have 2 newlines when
only one called for.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list