[Webkit-unassigned] [Bug 11596] New: KCanvasFilters rework

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=11596

           Summary: KCanvasFilters rework
           Product: WebKit
           Version: 420+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: SVG
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: zimmermann at kde.org


Similir to the work in patch 11468 (platform/graphics addition), KCanvasFilters
has to be reworked. It contains dozens of classes, cluttered in one file - same
for KCanvasFilterQuartz.h/mm.

My proposal is: (already discussed with Oliver)
Add new directory platform/graphics/svg/filters, and filters/cg.

Split up KCanvasFilters in quite some new classes, and move them to
platform/graphics/svg/filters.
Move the SVGResourceFilter class to platform/graphics/svg, similar to
masker/clipper resources.

Add the cg implementations of the filter effects in
platform/graphics/svg/filters/cg, named
SVGFETileCg.mm, SVGFEBlendCg.mm etc.

Move KCanvasPoint3F from kcanvas/device/KCanvasFilters.cpp/h to
platform/graphics/FloatPoint3D.

Move everything from kcanvas/device/quartz/filters/* to
platform/graphics/svg/filters/cg/.
(These are the cikernel files, all named Wk*Filter)

All these togeter kill KCanvasFilters.cpp/h and KCanvasFiltersQuartz.cpp/h,
this is the last
file in the kcanvas/ directory, it's empty now. kcanvas/device is the next
victim...

Attaching patch soon


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.