[Webkit-unassigned] [Bug 11501] REGRESSION: \u no longer escapes metacharacters in RegExps

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 13 11:12:09 PST 2006


http://bugs.webkit.org/show_bug.cgi?id=11501


sam.weinig at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11477|review?                     |review-
               Flag|                            |




------- Comment #6 from sam.weinig at gmail.com  2006-11-13 11:12 PDT -------
(From update of attachment 11477)
r- for a few more issues.

No spaces before *'s

+    _regex = pcre_compile(reinterpret_cast<const uint16_t
*>(cleanedPattern.data()), options, &errorMessage, &errorOffset, NULL);


Add a comment for:

+  while (pos != -1 + 2) {

Please make the new functions static. And add the URL for this bug to the
changelogs.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list