[Webkit-unassigned] [Bug 11501] REGRESSION: \u no longer escapes metacharacters in RegExps
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 8 06:44:35 PST 2006
http://bugs.webkit.org/show_bug.cgi?id=11501
sam.weinig at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11409|review? |review-
Flag| |
------- Comment #4 from sam.weinig at gmail.com 2006-11-08 06:44 PDT -------
(From update of attachment 11409)
Marking r- as a few style issues remain.
Please put spaces around infix operators.
+ next3 = (pos + 3 < length) ? code[pos+3].uc : -1;
the spaces inside the parenthesis are wrong even though they match the
surrounding style.
+ if ( !lastWasEscape ) {
The * should be next to the type.
+ _regex = pcre_compile(reinterpret_cast<const uint16_t
*>(cleanedPattern.data()), options, &errorMessage, &errorOffset, NULL);
Also, please regenerate the ChangeLog as the names of the new functions have
changed.
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list