[Webkit-unassigned] [Bug 11433] Fixes to get WebKit to run on windows
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 3 16:14:00 PST 2006
http://bugs.webkit.org/show_bug.cgi?id=11433
mjs at apple.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11350|review? |review-
Flag| |
------- Comment #10 from mjs at apple.com 2006-11-03 16:13 PDT -------
(From update of attachment 11350)
It's against the coding style guidelines to write single-line ifs with elses
like this:
if (px < enclosingRectMinX) enclosingRectMinX = px;
else if (px > enclosingRectMaxX) enclosingRectMaxX = px;
It would probably be simpler to write this by computing all four transformed
points and then using std::min and std::max to get the final coordinates, but
this way is fine too if you make it follow the style guidelines.
r- for the style issue.
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list