[Webkit-unassigned] [Bug 11405] Linux/Gdk build fixes

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=11405


mjs at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11320|review?                     |review-
               Flag|                            |




------- Comment #6 from mjs at apple.com  2006-11-01 19:13 PDT -------
(From update of attachment 11320)
Thanks for the patch! A few comments:

What warning do you get that resulted in these changes:

-            return NaN64AsBits;
+            return (uintptr_t)NaN64AsBits;

It would be nicer if NanAsBits was templatized on sizeof(uintptr_t) so that
this cast wasn't necessary. It's kind of sloppy to rely on the dead code paths
to be optimized out in the first place (admittedly a pre-existing flaw in the
code).

There is a more complete AffineTransformCairo attached to
<http://bugs.webkit.org/show_bug.cgi?id=11433>, I suggest starting with that.
There's one bug in that version which I pointed out in review comments. (I
think the right way to map a rect with a transform is to map each corner and
find the bounding box). However, the other version doesn't have all the
notImplemented() stuff this does, so you may want to start with that.

Otherwise, this looks great to me.

r- to consider the two points I raised. If you can't figure out how to do the
template solution for JSImmediate.h that's ok, that can be done later, but I
think it is worth taking the better AffineTransform.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.