[Webkit-unassigned] [Bug 11484] Fixing rendering of line edits on Qt platform

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 1 15:23:46 PST 2006


mjs at apple.com changed:

           What    |Removed                     |Added
  Attachment #11326|review?                     |review-
               Flag|                            |

------- Comment #2 from mjs at apple.com  2006-11-01 15:23 PDT -------
(From update of attachment 11326)
Thanks for the patch!

The code changes in this patch look fine.

However, I do not think the commented code would be the right approach to
handling a style that leaves less room for contents. Instead, the RenderTheme
should adjust the border and padding when adjusting the style in such cases.
Also we usually put "FIXME:" as a prefix for things like this that need to be
looked at, not "###". r- to give you a chance to update the comment but I'll
happily r+ once that is done (or if you decide to leave it as-is -- not such a
big deal). Either way, just reflag it when ready.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list