[Webkit-unassigned] [Bug 9183] New: Finish renaming of RenderCanvas to RenderView

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Wed May 31 04:42:40 PDT 2006


           Summary: Finish renaming of RenderCanvas to RenderView
           Product: WebKit
           Version: 420+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: ddkilzer at kilzer.net
                CC: hyatt at apple.com

Nearly 3000 tests broke when RenderCanvas was renamed to RenderView in r14638. 
This fix to WebCore/rendering/RenderView.h had to be checked in to make those
tests pass again (r14642):

-    virtual const char *renderName() const { return "RenderView"; }
+    // FIXME: Update this eventually and check in new layout tests.
+    virtual const char *renderName() const { return "RenderCanvas"; }

The layout tests should be easily updated by a simple find+perl command before

find LayoutTests -name \*-expected.txt -exec perl -p -i -e
's/\bRenderCanvas\b/RenderView/' {} \;

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list