[Webkit-unassigned] [Bug 5978] WebKIt+SVG should use SVGDocumentImpl for image/svg+xml

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Thu May 18 20:55:40 PDT 2006


darin at apple.com changed:

           What    |Removed                     |Added
   Attachment #8396|review?                     |review-
               Flag|                            |

------- Comment #5 from darin at apple.com  2006-05-18 20:55 PDT -------
(From update of attachment 8396)
Generally we don't like to check in commented-out or #if 0'd out code. I'd like
to understand why we need to do that here, such as in ~SVGDocument and

We also don't use braces around single line if statements like this one:

+  if (d->m_request.m_responseMIMEType == "image/svg+xml") {
+    d->m_doc =
+  } else

In SVGDOMImplementation, s_instance is no longer used so it should be removed.

What is isSVGDocument for? You add it here, but I don't see any uses of it.

Otherwise looks good.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list