[Webkit-unassigned] [Bug 8937] EncodingMap uses 0 as its empty value but 0 is a valid TextEncodingID
bugzilla-daemon at opendarwin.org
bugzilla-daemon at opendarwin.org
Thu May 18 08:47:01 PDT 2006
http://bugzilla.opendarwin.org/show_bug.cgi?id=8937
darin at apple.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #8391|review? |review+
Flag| |
------- Comment #6 from darin at apple.com 2006-05-18 08:46 PDT -------
(From update of attachment 8391)
Looks great, r=me.
One comment for the future. When you have an assert that has an && in it, it's
usually better to have two asserts. That way each one has a smaller expression
in it, and also if one fails you know which half failed.
--
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list