[Webkit-unassigned] [Bug 8331] DOMNodeLists returned to Objective-C are not properly wrapped

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Tue May 16 10:16:31 PDT 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=8331


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8343|review?                     |review+
               Flag|                            |




------- Comment #5 from darin at apple.com  2006-05-16 10:16 PDT -------
(From update of attachment 8343)
Lets not check in the RGBColor, Rect, and Counter stuff commented-out. I don't
like landing code with #if 0 around it.

Best way to keep track of that loose end is to write a bug report about it.

In valueForKey: it seems to me that we should be calling super in the
"!isSafeScript" case too.

Otherwise, this patch looks perfect!

I think I'm going to review+ this even though it has the #if 0 in it.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list