[Webkit-unassigned] [Bug 5264] document.createElementNS() should not allow to insert a second <html> element

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Mon May 15 14:39:30 PDT 2006


darin at apple.com changed:

           What    |Removed                     |Added
   Attachment #8328|review?                     |review-
               Flag|                            |

------- Comment #6 from darin at apple.com  2006-05-15 14:39 PDT -------
(From update of attachment 8328)
Looks great.

(In reply to comment #5)
> I think it will be hard to merge some of the functions. For instance
> HTMLElement::childAllowed
> really seems to be useful only for parsing, not for dom usage.

Right. Sorry, I didn't mean that we should merge them all. I was requesting
that you move the checks in Document, not all of the other parser-specific
checks. But I think that childAllowed also (eventually) needs a name that makes
it clear it's for parsing only.

> The changed test results are official dom cases that now pass, except
> documentnormalizedocument10.xhtml, which also "fails" in firefox. I think that
> test is broken though,
> the others probably need updated test results.
> Firefox behaves correctly, it throws the exception.

Sounds good. The patch should include the updated results for the DOM test

We should add a new test for document type, since we're changing the behavior
of that too.

r=me on the code change, but please post a patch that includes the test result
changes and a change log for LayoutTests.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list