[Webkit-unassigned] [Bug 8813] Optimizing +[DOMNode _nodeWith:]
bugzilla-daemon at opendarwin.org
bugzilla-daemon at opendarwin.org
Tue May 9 17:42:31 PDT 2006
http://bugzilla.opendarwin.org/show_bug.cgi?id=8813
darin at apple.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #8191|review? |review+
Flag| |
------- Comment #2 from darin at apple.com 2006-05-09 17:42 PDT -------
(From update of attachment 8191)
Looks great, r=me.
Some minor comments that should not prvent us landing this:
+static ObjcClassMap *objcClassMap;
The * should be next to the type rather than the variable.
I think ObjC is clearer than Objc.
+ // Populate it with DOM Element classes.
I would say "element" not "Element".
+ addObjcClassForTag(htmlTag, [DOMHTMLHtmlElement class]);
Sorting these alphabetically would make it easier to see if something is in the
list or not.
--
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list