[Webkit-unassigned] [Bug 8789] New: RenderStyle::getPseudoStyle() always returns 0

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=8789

           Summary: RenderStyle::getPseudoStyle() always returns 0
           Product: WebKit
           Version: 420+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: opendarwin.org at mitzpettel.com


While working on bug 8760 I noticed that RenderStyle::getPseudoStyle() never
breaks out of the while loop, since it tries to match styleType() instead of
ps->styleType(), and therefore always returns 0, potentially causing redundant
calls to createPseudoStyleForElement() and addPseudoStyle().

Unfortunately, canging
            if (styleType() == pid)
to
            if (ps->styleType() == pid)
doesn't work, since for things like :after and :hover:after you need to keep
two pseudoStyles of the same styleType (or have a rule for deciding which one
to keep). Making the trivial change regresses
fast/css-generated-content/hover-style-change.html.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.