[Webkit-unassigned] [Bug 8132] CSS parser sometimes accepts real number as integer

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=8132


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8141|review?                     |review-
               Flag|                            |




------- Comment #4 from darin at apple.com  2006-05-07 10:28 PDT -------
(From update of attachment 8141)
 num             [0-9]+|[0-9]*"."[0-9]+
+intnum          [0-9]+|[0-9]*

This looks wrong to me. [0-9]+ would be correct, the [0-9]* part is not
relevant nor do we need a "|".

I'm also unclear on how flex handles the ambiguity since both {num} and
{intnum} can match the same thing. We might need to rearrange the regular
expressions so that is not the case.

I suggest using INTEGER instead of INTNUMBER and perhaps changing the name of
NUMBER to something like FLOAT.

We need a test case. We don't check in bug fixes without test cases.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.