[Webkit-unassigned] [Bug 6608] REGRESSION: Line disappears when deleting

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=6608


justin.garcia at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-                     |justin.garcia at apple.com
                   |unassigned at opendarwin.org   |
             Status|NEW                         |ASSIGNED
   Attachment #7391|                            |review?
               Flag|                            |




------- Comment #5 from justin.garcia at apple.com  2006-03-30 08:17 PDT -------
Created an attachment (id=7391)
 --> (http://bugzilla.opendarwin.org/attachment.cgi?id=7391&action=view)
patch

Rewrote moveNodesAfterNode to address several problems:
It moves nodes w/o worrying about how their style might change during the move.
It traverses _siblings_ looking for a br to know that it's at the end of the paragraph to merge.  If the br is burried inside a span, it won't find it.  If the text is whitespace:pre, it won't find stop at the end of the paragraph.
It reinserts the nodes at strange places, which was causing the bug.

This patch passes all pixel tests.  Render tree diffs are 1) fixes 2) placeholder brs were there were none.  This patch inserts them more aggressively to make sure that inline content after the merged paragraph doesn't collapse onto the line where the paragraph was moved to.  I'm writing lots of layout tests to illustrate problems with the old function and thinking hard about how to break the new code.

-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.