[Webkit-unassigned] [Bug 7989] Win32: User Agent shouldn't be hardcoded in TransferJobWin

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=7989


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7335|review+                     |review-
               Flag|                            |




------- Comment #9 from darin at apple.com  2006-03-29 05:05 PDT -------
(From update of attachment 7335)
This uses String::ascii, but this is what PlatformString.h says:

#ifndef NDEBUG
    // For debugging only, leaks memory.
    const char *ascii() const;
#endif

So this won't even compile when NDEBUG is set. We need a solution that doesn't
involve the ascii() function.

A short term hack would be to use DeprecatedString's ascii() function. A better
fix would be to add an appropriate conversion for String for this case; perhaps
a way to convert to an ASCII string that doesn't leak memory or a way to
convert to a Windows wchar_t* so we can use InternetOpen rather than
InternetOpenA?


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.