[Webkit-unassigned] [Bug 7984] ifdef win32 specific code in GraphicsContextCairo.cpp

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=7984


macdome at opendarwin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7312|review?                     |review-
               Flag|                            |




------- Comment #4 from macdome at opendarwin.org  2006-03-27 20:12 PDT -------
(From update of attachment 7312)
These should be changed to use PLATFORM(WIN_OS) and PLATFORM(LINUX_OS) macros. 
They also should just be made into an ||

#if PLATFORM(WIN_OS) || PLATFORM(LINUX_OS)
cairo_t* platformContext() const
#endif

also, we do not commit commented out code, so 
//typedef struct _GdkDrawable GdkDrawable

It looks like in total you're not adding anything to the file.  You should just
change the required #if lines to include linux in an or instead of duplicating
them.


------- Comment #5 from macdome at opendarwin.org  2006-03-27 20:12 PDT -------
(From update of attachment 7312)
These should be changed to use PLATFORM(WIN_OS) and PLATFORM(LINUX_OS) macros. 
They also should just be made into an ||

#if PLATFORM(WIN_OS) || PLATFORM(LINUX_OS)
cairo_t* platformContext() const
#endif

also, we do not commit commented out code, so 
//typedef struct _GdkDrawable GdkDrawable

It looks like in total you're not adding anything to the file.  You should just
change the required #if lines to include linux in an or instead of duplicating
them.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.