[Webkit-unassigned] [Bug 7868] REGRESSION: Extraneous focus ring drawn at the end of the page

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Fri Mar 24 08:19:12 PST 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=7868


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7275|review?                     |review-
               Flag|                            |




------- Comment #9 from darin at apple.com  2006-03-24 08:19 PDT -------
(From update of attachment 7275)
Looks good. Almost ready to go.

Should use rect.isEmpty() rather than explicit checks for 0. (And if we were
keeping the checks for 0, need spaces around the "==".)

And we need the test in the patch as a layout test (even if only pixel test
results will show the focus ring).

Then I'll review+.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list