[Webkit-unassigned] [Bug 7938] New: Shave .2% on PLT by removing bogus strcmp.

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Thu Mar 23 11:45:38 PST 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=7938

           Summary: Shave .2% on PLT by removing bogus strcmp.
           Product: WebKit
           Version: 420+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: normal
          Priority: P4
         Component: SVG
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: macdome at opendarwin.org


For whatever reason we had a completely bogus strcmp in HTMLTokenizer which
accounted for .2% of all time spent in the PLT (on my MBP):

@@ -901,7 +900,7 @@
                     ptr[--len] = '\0';

                 // Now that we've shaved off any invalid / that might have
followed the name), make the tag.
-                if (ptr[0] != '!' && strcmp(ptr, "!doctype") != 0) {
+                if (ptr[0] != '!') { // make sure it's not a !DOCTYPE
                     currToken.tagName = AtomicString(ptr);
                     currToken.beginTag = beginTag;
                 }


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list