[Webkit-unassigned] [Bug 7852] New unicode abstraction layer

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=7852





------- Comment #6 from mjs at apple.com  2006-03-21 01:20 PDT -------
It's nice that the API layer came out so thin.

I don't think George needs to perfect the abstraction in all ways before
landing. But there are the following issues, I believe:

* The patch shows an include of one of the platform-specific headers. I think
it would be better to include a single header, which uses PLATFORM macros to
pick the right per-platform implementation.

+#include "unicode/qt4/kjs_unicode.h"

* This method is not implemented in the ICU code path:

inline CharCategory category(unsigned short c)

* I think it would be better to put this in kxmlcore instead of kjs, so it can
be used in the future by WebCore and/or khtml.

I think enhancing the API to go beyond KJS's current uses can be done in a
separate pass, but these issues seem relatively important.

r- for now because I think the included patch would break the JavaScriptCore
build and we need to straighten out the header issue.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.