[Webkit-unassigned] [Bug 7831] .apply/call does not set this for eval

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=7831


tolmasky at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7146|                            |review?
               Flag|                            |




------- Comment #6 from tolmasky at gmail.com  2006-03-18 01:25 PDT -------
Created an attachment (id=7146)
 --> (http://bugzilla.opendarwin.org/attachment.cgi?id=7146&action=view)
Modified Patch

I ended up having to make a significantly different patch for this.  The old
one, while working, caused a regression in Expressions/1.11.1.js or so.  The
problem is that callAsFunction always gets sent a thisObj, so its not enough to
check whether thisObj isn't null or undefined to see whether we are actually
being called from an apply or call.  So the solution I came up with was to
trick it by creating an inbetween ExecState that contains the correct thisObj. 
I wanted to float this by you guys as whether it was an acceptible solution or
not before writing a changelog/tests for it, since it does seem a bit hackish. 
Also, this new patch fixes js1_6/Array/regress-304828.js .


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.