[Webkit-unassigned] [Bug 7831] .apply/call does not set this for eval

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=7831


mjs at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7133|review?                     |review-
               Flag|                            |




------- Comment #3 from mjs at apple.com  2006-03-17 11:48 PDT -------
(From update of attachment 7133)
The substance of the change looks good. I have some style concerns:

1) I don't think you need comments explaining what the code used to do or why
it was wrong. That can go in the ChangeLog.

2) This if statement shouldn't be all on one line.

+               if(!thisObj||thisObj->isUndefinedOrNull()) thisObj=
static_cast<JSObject *>(exec->context().thisValue());

Can thisObj ever actually truly be a null pointer as opposed to JS null?

3) Needs a ChangeLog entry.

4) Needs a test case - you can look in LayoutTests/fast/js/resources/*.js, make
a JS file like that using shouldBe and then use make-js-test-wrappers to make
the HTML wrapper.

r- for ChangeLog and test case, but the substance of the change looks correct.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.