[Webkit-unassigned] [Bug 7761] Tabs in class attribute not treated as whitespace

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=7761





------- Comment #6 from darin at apple.com  2006-03-15 10:38 PDT -------
(In reply to comment #5)
> In that case, this patch uses AtomicString(classAttr) instead of
> AtomicString(str, length), but I almost convinced myself that there is no
> difference.

You're right, there is no difference. To make a difference we'd have to change
the code path so that the attribute stays an atomic string. Currently the
attribute starts out an atomic string in the attribute, but then:

    1) AttrImpl::value() changes it into a plain string (should be changed to
return AtomicString)
    2) calling parseClassAttribute would also change it into a plain string
(should be changed to pass an AtomicString)

Also, lowercasing inside parseClassAttribute has to be done carefully; the code
does seem to be doing that right already.

But if we took care of all of those, then we could have a fast path. I'm not
certain it would matter, but it seems like it would be a win. But lets not
require that be in this patch.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.