[Webkit-unassigned] [Bug 7761] Tabs in class attribute not treated as whitespace

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Wed Mar 15 10:01:28 PST 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=7761


opendarwin.org at mitzpettel.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7089|                            |review?
               Flag|                            |




------- Comment #5 from opendarwin.org at mitzpettel.com  2006-03-15 10:01 PDT -------
Created an attachment (id=7089)
 --> (http://bugzilla.opendarwin.org/attachment.cgi?id=7089&action=view)
Revised patch

(In reply to comment #3)
> OK, let me now be crazy and make premature optimization comments:

Yay! I followed your suggestions in this version.

> Do we want to optimize the common case [...] so that we
> don't create a new atomic string for that case?

In that case, this patch uses AtomicString(classAttr) instead of
AtomicString(str, length), but I almost convinced myself that there is no
difference.

> Not sure what to do about these nitpicks. The code is good as is.

Not really... it was also checking each boundary character twice!


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list