[Webkit-unassigned] [Bug 7726] REGRESSION: orbitz calendar fails (JavaScript function serialization/parsing)

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=7726





------- Comment #7 from darin at apple.com  2006-03-13 21:19 PDT -------
This boils down to incorrect code on the Orbitz site that just happens to work
in other browsers. Someone should report that to Orbitz.

But it's relatively easy to fix JavaScriptCore so this is not a problem. I see
a few differences from Gecko:

    a) Functions made with "new Function" in Gecko get the name "anonymous",
while JavaScriptCore leaves them without names.
    b) Functions for event handlers are named after the attribute in Gecko,
while WebCore leaves them without names.
    c) Gecko puts function declarations at the beginnings of new lines when
serializing. JavaScriptCore does not.
    d) Gecko allows you to parse a function with no function name in the
expression passed "new Function".
    e) Gecko formats the functions a bit differently (brace on the same line as
the function name).

To fix the bug, all we have to do is resolve (a), which is a tiny patch to
JavaScriptCore. I have changes for (a), (b), and (c) in my tree now. I think
(d) is something we get right and Gecko gets wrong. I think (e) is something we
might want to consider doing, just to reduce the chance of a another bug like
this one where someone depends on the details of behavior a bit too much.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.