[Webkit-unassigned] [Bug 5122] Equivalent of Mozilla's DOMContentLoaded needed
bugzilla-daemon at opendarwin.org
bugzilla-daemon at opendarwin.org
Thu Mar 9 03:13:17 PST 2006
http://bugzilla.opendarwin.org/show_bug.cgi?id=5122
------- Comment #8 from pumpkingod at gmail.com 2006-03-09 03:13 PDT -------
(In reply to comment #7)
> (From update of attachment 6950 [edit])
> In general this change looks really good, a few small comments (also mentioned
> on IRC):
>
> - The test case doesn't need to do the fibonnacci thing, JS is single-threaded
> so that doesn't really add anything.
>
> - The test case could check a few more things. For instance, it could load an
> external image or stylesheet or something, and verify that DOMContentLoaded
> fires before the subresource onload event (this isn't guaranteed, but in the
> layout test case it shouldn't be in cache). You could also check that the whole
> document is parsed by checking for instance that the last element of the
> document is there as expected.
>
> - There's no need to specially filter this event like DOM mutation events, it
> is not gonna fire often enough to need the optimization.
>
> You can probably get rid of this comment:
>
> + // I think this is the right place for the DOMContentLoaded trigger, but
> maybe not...
>
> r- for these technicalities, can't wait to see the updated version.
>
ran into a really strange bug while trying to fix those, so I'll probably have
it in by tomorrow :)
--
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list