[Webkit-unassigned] [Bug 4840] Frames only resize wider, can't make them narrower

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=4840


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6833|review?                     |review-
               Flag|                            |




------- Comment #6 from darin at apple.com  2006-03-04 11:47 PDT -------
(From update of attachment 6833)
We would like a capturing mechanism that works for all drags. But adding one
specifically for the frameset resizing seems fine for now.

It's not good to add stuff about resizing to the DOM, though. This should stay
in the view system (rendering and FrameView).

+    DocumentImpl *d = getDocument();
+    FrameView *w = d ? d->view() : 0;
+    if (w)
+        w->setResizingFrameSet(e ? this : 0);

getDocument no longer ever returns 0 -- nodes now reference their document --
so we don't need a nil-check on the document. I'd also like to see the
FrameView* style used instead of FrameView * as per our style guidelines. But
this function should go.

RenderFrameSet::setResizing should handle this directly, calling the FrameView.
You don't need a boolean in the renderer or the DOM element.

Nice fix in hoverTimerFired.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.