[Webkit-unassigned] [Bug 7555] :hover style not applied on hover if its display property is different from original style's

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=7555





------- Comment #3 from darin at apple.com  2006-03-03 06:42 PDT -------
(From update of attachment 6822)
I have a couple questions.

    1) Is there a guarantee that neither hoverNode or activeNode can be
deallocated inside attach() or detach()? I seem to recall that attach() could
cause an entire subframe to load and thus run JavaScript. If that's so,
hoverNode and activeNode need to be RefPtr<NodeImpl> to avoid calling
renderer() and parent() on a deallocated object. On the other hand, I don't see
anyone doing a ref/deref on the element itself, so perhaps this is not a real
issue.

    2) Regarding moving the hover/active node to the first parent that has a
renderer, is that OK for the case where children are newly added? It seems that
in some case the new proper hover or active node might be a child of the old
one? Does this get fixed later when a hover timer fires?

It might also be nice to put:

+            m_hovered = wasHovered;
+            m_active = wasActive;

inside the "if (attached())" statement. Really a very minor thing.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.