[Webkit-unassigned] [Bug 3812] XMLHttpRequest: PUT, DELETE, HEAD and all other methods but POST actually do a GET

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=3812


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6786|review?                     |review+
               Flag|                            |




------- Comment #9 from darin at apple.com  2006-03-01 08:42 PDT -------
(From update of attachment 6786)
Change looks fine as is, but I have three comments:

    1) Is there a test for the change in JSXMLHttpRequest.cpp? That change
looks fine, but I'd like to see a test that was broken before and fixed now.

    2) Since method is now a String you can use equalIgnoringCase rather than
calling lower when comparing the method with head.

    3) I would like the client pointer to be the first parameter to TransferJob
and the method the second parameter, because the client pointer sort of a "back
pointer to the claler" while the rest of the parameters are the specification
of what the job is to do.

The most important of these three is (1), but I think none are a big enough
deal to prevent landing the patch. I'll say r=me.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.