[Webkit-unassigned] [Bug 8515] Linux porting compile bug

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=8515





------- Comment #49 from darin at apple.com  2006-06-30 08:30 PDT -------
(From update of attachment 9064)
There is still a lot here that's not formatted right. Extra spaces in
parentheses, missing spaces after if keywords, commas, and around operators,
const after type in some files. It doesn't seem too challenging to fix these.
If we don't fix it now, I'm not sure when we would.

I'm also wondering about file names with "Gdk" in them -- shouldn't it be all
capitals GDK?

We don't normally check in #if 0'd code and commented out code, and there's a
lot of both here.

Macro names need to be all capitals.

Comments like this:

+    //XXX create a new one here !

aren't really useful unless other people on the project know what "XXX" means
what a "new one" is.

We try to keep all the stubs in a single file, but 
I'm mystified by other loose ends like the stubs and loadResourceIntoArray
function which are defined in FrameGdk.cpp -- clearly seems the wrong place for
these things.

Now that the constants in KeyboardCodes.h are plain old namespaced const, they
should no longer be all capitals -- that's for macros only.

+                                      (GSourceFunc)timeout_cb,

We don't do typecasts on function types because that often leads to trouble.
Instead we use function types that exactly match and do typecasting on the
types inside the functions -- a lot safer -- I can go into more detail about
this if you like. It's something I really learned the importance of while
working on Nautilus for the Gnome project.

RenderThemeGdk.cpp has comments in it about Windows Theme API that are not
correct or appropriate.

 #include "kjs_html.lut.h"
+#include <math.h>

This include is in the wrong place; should be up with the other includes, not
after the "lut.h" include.

On the other hand, it's possible that I should ignore these issues and
rubber-stamp this so we can get the GDK port into the tree, regardless of the
many small problems in the code.

But I'm not entirely comfortable with that. I'd like to see as many of these
issues as possible fixed. I'd feel a lot better about taking this into the tree
if it didn't have all the minor problems I mention above.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.