[Webkit-unassigned] [Bug 8194] Style spans with no style are not always deleted

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=8194


Graham.Dennis at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-                     |Graham.Dennis at gmail.com
                   |unassigned at opendarwin.org   |
             Status|NEW                         |ASSIGNED
   Attachment #9076|                            |review?(justin.garcia at apple.
               Flag|                            |com)




------- Comment #2 from Graham.Dennis at gmail.com  2006-06-28 07:53 PDT -------
Created an attachment (id=9076)
 --> (http://bugzilla.opendarwin.org/attachment.cgi?id=9076&action=view)
patch

The bug is caused because when applying a style to part of a #text node, a
style span is created around it before the #text node is split. Later, when the
empty style spans are being cleaned up, iteration proceeds from the inserted
node to its ancestors, but stopping when a node has a sibling before/after it
as appropriate. In this case, the empty style span is missed because the span
is one level further up. I'm not sure if this is the correct fix, but I've
simply changed the cleanup code to iterate from the node where the style was
changed all the way back to the root editable element cleaning up empty style
spans along the way.

Included in this patch is an automated testcase. This patch passes the layout
tests except for:
editing/style/remove-underline-across-paragraph-in-bold
editing/style/remove-underline-in-bold
editing/style/typing-style-003
The only changes for these testcases however is the removal of the empty style
spans.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.