[Webkit-unassigned] [Bug 9571] Teach svn-apply and svn-unapply to handle directory adds and removes better

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=9571


ddkilzer at kilzer.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9013|                            |review?
               Flag|                            |




------- Comment #1 from ddkilzer at kilzer.net  2006-06-24 22:53 PDT -------
Created an attachment (id=9013)
 --> (http://bugzilla.opendarwin.org/attachment.cgi?id=9013&action=view)
Patch v1

Changes to svn-apply:

- Sorted subroutines alphabetically; handleBinaryChange() moved but did not
change; addDirectoriesIfNeeded() was moved and had major changes.
- Changed addDirectoriesIfNeeded() subroutine to operation without changing
directories.  Keep track of directories checked for adding in
%checkedDirectories global.  Removed $startDir global variable.
- Extracted svnStatus() subroutine from existing code.
- Added removeDirectoriesIfNeeded() subroutine to check for empty directories. 
It is called after all patches have been applied.
- Added isDirectoryEmptyForRemoval() subroutine used by
removeDirectoriesIfNeeded() to determine if a directory is empty or not.  This
sub uses the %removeDirectoryIgnoreList global to filter out directories to
ignore when checking if a given directory is empty.  Note that "return" can't
be used in the grep{} code block, otherwise that will cause the entire function
to return.

Changes to svn-unapply:

- Sorted subroutines alphabetically; unapplyPatch() was moved but did not
change.
- Extracted svnStatus() subroutine from existing code.
- Removed unused $startDir global variable.
- Added revertDirectories() subroutine.  Uses %directoriesToCheck global
variable when running.  This variable is set as patches are unapplied.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.