[Webkit-unassigned] [Bug 7204] float inserted in fixed height block via DOM not repainted

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=7204


hyatt at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8865|review?                     |review-
               Flag|                            |




------- Comment #7 from hyatt at apple.com  2006-06-23 22:26 PDT -------
(From update of attachment 8865)
I'm not convinced on this one quite yet.  When a float moves during layout, it
should still get its coordinates changed in the floating objects list of the
block that will ultimately paint it.

What bothers me about this patch is that it will end up repainting the same
float over and over when you have a bunch of nested blocks that all have the
same float in their floatingObjects list.

I also don't quite understand your point about repaintAfterLayout vs.
repaintDuringLayout since the former uses getAbsoluteRepaintRectIncludingFloats
(which also has the !noPaint check).

Also for a check like this:

+            if (paintAll || !r->noPaint && !r->node->layer()) {                

You'll do a repaint even of something with a layer, and that's not necessary
(since layers handle repainting themselves properly already... make the same
test case with position:relative on the float and you'll see it work I bet).


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.