[Webkit-unassigned] [Bug 9532] date setUTCFullYear to setUTCMinutes adding 1 hour in time zone 0

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Fri Jun 23 21:37:17 PDT 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=9532





------- Comment #4 from darin at apple.com  2006-06-23 21:37 PDT -------
(From update of attachment 8988)
I don't like the fact that the call to localtime_r is now dependent on the
current time. Perhaps that's a clever elegant solution, but I'm worried that
makes this function "less deterministic". And the local variable clearly should
not be named zero if it's going to be used this way.

We really want the utcOffset at time t, not the utcOffset at the current time.

I'm not absolutely certain of this, but I think I'm certain enough to say
review-.

Feel free to research further and put this up for review again if I'm wrong.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list