[Webkit-unassigned] [Bug 8707] event.clientX and event.clientY should be relative to the viewport, not the canvas

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=8707


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8970|review?                     |review-
               Flag|                            |




------- Comment #12 from darin at apple.com  2006-06-23 21:26 PDT -------
(From update of attachment 8970)
Almost there!

I still think that the local variables in EventTargetNode::dispatchMouseEvent
should not be named offsetX/Y. Instead I think we should have pageX/Y local
variables and do -= statements inside the if statement.

+    if (FrameView *view = document()->view()) {

Formatting wrong here -- * should be next to FrameView.

-                                                   document()->defaultView(),
e.globalX(), e.globalY(), pos.x(), pos.y(),
-                                                   e.ctrlKey(), e.altKey(),
e.shiftKey(), e.metaKey());
+                                                   document()->defaultView(),
e.globalX(), e.globalY(),
+                                                   pos.x(), pos.y(),
e.ctrlKey(), e.altKey(), e.shiftKey(), e.metaKey());

Should roll this change out -- it's just reformatting.

What guarantees that neither frame() or view() will be 0 in the WheelEvent
constructor?

Between these small issues, I think I still give this a review-, but it's about
ready to land. The only one I'm really concerned about is the WheelEvent
constructor nil-check issue.

Also, the layout test does not test the wheel event code.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.