[Webkit-unassigned] [Bug 9507] Empty style spans created in applyInlineStyle

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=9507





------- Comment #3 from Graham.Dennis at gmail.com  2006-06-20 06:20 PDT -------
Created an attachment (id=8932)
 --> (http://bugzilla.opendarwin.org/attachment.cgi?id=8932&action=view)
testcase

Testcase.
ToT generates an empty <font> tag between 'foo' and 'bar'. This patch removes
the reason that tag was created.

This patch passes all testcases except the two mentioned in my previous
message.
One thing I didn't explain about the patch is the lines:
if (node->isAncestor(endNode)
    endNode = endNode->traverseNextSibling();
The reason for this is that if you have HTML like
<block1>
<block2></block2></block1>
the 'start' position can be (block1, 0) after removeInlineStyle() (just before
this patch), and the end position can be (block1, 1), now in this case the if
(start.offset() >= start.node()->caretMaxOffset()) line can move the 'start'
node forward to block2, and so when a traversal is done (via traverseNextNode),
the current node will never be reach the end node, and so the exit condition
will never be reached.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.