[Webkit-unassigned] [Bug 6282] Adding new Option with new Option(text, value, defaultSelected, selected) fails to update selectedIndex

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Sun Jun 11 16:28:59 PDT 2006


darin at apple.com changed:

           What    |Removed                     |Added
   Attachment #8801|review?                     |review-
               Flag|                            |

------- Comment #10 from darin at apple.com  2006-06-11 16:28 PDT -------
(From update of attachment 8801)
Test case looks great, but also need expected results! (including pixel
results, unless it's a "dump as text test", which is the preferred style).

HTMLSelectElement::setOption and HTMLSelectElement::setLength are written here
assuming that the passed in "ec" is already 0. In general, functions should not
be written that way. Callers are not obliged to set up ec before calling if
they intend to ignore it. The rule is "caller must set exception code to 0 if
and only if caller looks at it to determine success; implementers may set the
exception code to 0 or leave it untouched on success".

Otherwise, looks great.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list