[Webkit-unassigned] [Bug 8515] Linux porting compile bug

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Fri Jun 9 11:44:57 PDT 2006


darin at apple.com changed:

           What    |Removed                     |Added
   Attachment #8780|review?                     |review+
               Flag|                            |

------- Comment #23 from darin at apple.com  2006-06-09 11:44 PDT -------
(From update of attachment 8780)
+    void setFont(cairo_t* cr) const;

We would leave out "cr" here.

+    Glyph getGlyphIndex(UChar c) const { return m_font.index (c); }

We would not put a space after index and before "(c)".

I think you should use round rather than nearbyint -- nearbyint is affected by
the prevailing rounding mode.

 #include "config.h"
+#include <math.h>
 #include "HTMLCanvasElement.h"

The <math.h> include should go a little further down. The concept is that the
.cpp file includes its own header file.

These are minor issues, so r=me.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list