[Webkit-unassigned] [Bug 8331] DOMNodeLists returned to Objective-C are not properly wrapped

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=8331





------- Comment #9 from mjs at apple.com  2006-06-02 00:22 PDT -------
The fix to wrap the miscellaneous DOM objects properly is a great one. However,
it's mixed in with a bunch of other KVO-related changes which should really be
separate patches.

Some specific comments about some of the changes:

I don't think it's a good idea to sprinkle KVO-specific changes into the core
DOM code, such as this change in Node.cpp:

+    
+    willChangeValueForKey("childNodesArray");
+    
     NodeListSet::iterator end = m_nodeLists->end();
     for (NodeListSet::iterator i = m_nodeLists->begin(); i != end; ++i)
         (*i)->rootNodeChildrenChanged();
+    
+    didChangeValueForKey("childNodesArray");

It also doesn't seem right; the willChange is getting called after the value
actually gets changed.

I think it would be better for KVO to hook in using a more general DOM
mechanism.

I think the change to create the right wrapper is great, so please re-upload
that, and put the other stuff in a separate patch in its own bug please.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.