[Webkit-unassigned] [Bug 9181] Complete DOMUIEvent Obj-C API to reflect UIEvent

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Thu Jun 1 05:37:07 PDT 2006


jonas.witt at gmail.com changed:

           What    |Removed                     |Added
Attachment #8620 is|0                           |1
           obsolete|                            |

------- Comment #7 from jonas.witt at gmail.com  2006-06-01 05:37 PDT -------
Created an attachment (id=8639)
 --> (http://bugzilla.opendarwin.org/attachment.cgi?id=8639&action=view)
Patch to add DOMKeyboardEvent, DOMWheelEvent

This patch adds DOMKeyboardEvent (DOM Level 3 Events-compliant). It also adds
DOMWheelEvent as a non-standard event in a seperate file and two non-standard
methods of DOMKeyboardEvent (keyCode and charCode). I've also added the
copyright notice and Changelog entries, as Geoffrey said. I've removed the
classes from the second patch that don't need to be exposed.

Regarding testing: I've done testing of all properties using a simple WebView +
test HTML file, an event listener set up to listen to all events and manual
checking. Everything works fine for me. I couldn't figure out how/where to add
something to DumpRenderTree, sorry. It doesn't even compile (unmodified), so I
guess I just don't understand it. If someone can give a hint or two, I may be
able to do this, though.

Regarding public API/review process: Maybe one could also add documentation, as
everything DOMEvent-related is missing from the ADC Reference Library. I don't
know who would (be able to) do that.

Regarding .idl files: I see that the generation is done in Perl. I don't speak
Perl and generally have no experience with such things, so I probably can't do
this. But it doesn't hurt when the manually written DOMKeyboardEvent from my
patch is included now, IMO.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list