[Webkit-unassigned] [Bug 10176] Make WebCore compile with -Wundef

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Mon Jul 31 18:54:14 PDT 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=10176


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9783|review?                     |review-
               Flag|                            |




------- Comment #2 from darin at apple.com  2006-07-31 18:54 PDT -------
(From update of attachment 9783)
+#if defined(SPEED_DEBUG) && SPEED_DEBUG < 1

That's definitely wrong. This needs to compile if SPEED_DEBUG is not defined.

THe other ones look pretty good, but I'd prefer that it consistently use #ifdef
rather than a mix of #ifdef and #if defined.

Seems that all the #if __APPLE__ need to be changed too, although not on the OS
X platform.

review- because of the SPEED_DEBUG mistake.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list