[Webkit-unassigned] [Bug 10159] New: Regression: delegate returning no menu elements crashes webkit

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10159

           Summary: Regression: delegate returning no menu elements crashes
                    webkit
           Product: WebKit
           Version: 420+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: normal
          Priority: P2
         Component: WebKit API
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: duncan at mclink.it


svn r14845 has a fix for <rdar://problem/4498606> REGRESSION (417.8-420+): 3
missing items (but extra separators) in context menu in Mail message body

However if the context menu delegate returns no items, as in:

- (NSArray *)webView:(WebView *)sender contextMenuItemsForElement:(NSDictionary
*)element defaultMenuItems:(NSArray *)defaultMenuItems
{
        return [NSArray array];
}

the patch above crashes because it doesn't check for zero menu items.

The fix is trivial, attaching the patch.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.