[Webkit-unassigned] [Bug 10080] Adopt gcc -pedantic changes from the Unity project to improve cross-compiler compatibility

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10080


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9750|review?                     |review-
               Flag|                            |




------- Comment #8 from darin at apple.com  2006-07-28 15:18 PDT -------
(From update of attachment 9750)
+        Vector<JSValueRef> arguments(argumentCount);

For efficiency, this should use the feature of Vector where it uses storage on
the stack if it fits. Like this:

        Vector<JSValueRef, 256> arguments(argumentCount);

The comments in the change log do not mention the change from C++ style
comments to plain C comments, nor the motivation for that change. I'd like to
understand why a Mac-OS-X-only prefix file needs that change.

Change log doesn't mention changing from ABS macro to abs function.

Change log doesn't mention changing from -HUGE_VAL to
-numeric_limits<double>::max(), but also, that should probably be
numeric_limits<double>::min() instead. Also -HUGE_VAL is actually negative
infinity, which is even better. Is there some portable way to get negative
infinity?


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.